Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove badges from README.md prior to converting to HTML #124

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

spetrosi
Copy link
Contributor

  • Remove thematic break after badges
  • Remove badges from README.md prior to converting to HTML

Signed-off-by: Sergei Petrosian [email protected]

@spetrosi spetrosi force-pushed the update_role_files branch 2 times, most recently from 2fb3b37 to 36096a0 Compare August 25, 2023 06:54
Copy link
Collaborator

@ueno ueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor idea: perhaps you could explicitly mark the badge line with an HTML comment which GFM ignores, e.g.,:

<!-- badges -->[![ansible-lint.yml](...)

and then in the workflow file:

sed -i '/^<!-- badges -->/d' ...

@spetrosi
Copy link
Contributor Author

I would like to avoid additional comments, and I think the current sed expression is specific enough. Maybe though I can change the current expression to only work on the first 8 lines to avoid removing unwanted lines afterwards.

- Remove thematic break after badges
- Remove badges from README.md prior to converting to HTML

Signed-off-by: Sergei Petrosian <[email protected]>
@spetrosi spetrosi merged commit 3ae4996 into main Aug 28, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants