-
Notifications
You must be signed in to change notification settings - Fork 50
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ci: fix python unit test - copy pytest config to tests/unit
This is fixed by tox-lsr 3.2.2 - all actions that use tox-lsr are updated to 3.2.2, not just the python unit tests, even though the fix is only related to pytest. All roles are updated to use tox-lsr 3.2.2 for the sake of consistency even if not affected by the pytest issue. Something changed recently in the way github actions provisions systems which means some of the directories are not readable by the python unit test actions. In addition, the python unit tests were causing a lot of unnecessary directory traversal doing collection/discovery of unit test files, because of using `pytest -c /path/to/tox-lsr/pytest.ini` Unfortunately, with `pytest`, the directory of the config file is the root directory for the tests and tests discovery, and there is no way around this. Therefore, the only solution is to copy the tox-lsr `pytest.ini` to the `tests/unit` directory, which makes that the test root directory. See also linux-system-roles/tox-lsr#160 Signed-off-by: Rich Megginson <[email protected]>
- Loading branch information
Showing
5 changed files
with
5 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,7 +32,7 @@ jobs: | |
- name: Install tox, tox-lsr | ||
run: | | ||
set -euxo pipefail | ||
pip3 install "git+https://github.com/linux-system-roles/[email protected].1" | ||
pip3 install "git+https://github.com/linux-system-roles/[email protected].2" | ||
- name: Convert role to collection format | ||
run: | | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,7 +30,7 @@ jobs: | |
- name: Install tox, tox-lsr | ||
run: | | ||
set -euxo pipefail | ||
pip3 install "git+https://github.com/linux-system-roles/[email protected].1" | ||
pip3 install "git+https://github.com/linux-system-roles/[email protected].2" | ||
- name: Run ansible-plugin-scan | ||
run: | | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,7 +30,7 @@ jobs: | |
- name: Install tox, tox-lsr | ||
run: | | ||
set -euxo pipefail | ||
pip3 install "git+https://github.com/linux-system-roles/[email protected].1" | ||
pip3 install "git+https://github.com/linux-system-roles/[email protected].2" | ||
- name: Run ansible-plugin-scan | ||
run: | | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,7 +33,7 @@ jobs: | |
- name: Install tox, tox-lsr | ||
run: | | ||
set -euxo pipefail | ||
pip3 install "git+https://github.com/linux-system-roles/[email protected].1" | ||
pip3 install "git+https://github.com/linux-system-roles/[email protected].2" | ||
- name: Convert role to collection format | ||
run: | | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -58,7 +58,7 @@ jobs: | |
run: | | ||
set -euxo pipefail | ||
python -m pip install --upgrade pip | ||
pip install "git+https://github.com/linux-system-roles/[email protected].1" | ||
pip install "git+https://github.com/linux-system-roles/[email protected].2" | ||
# If you have additional OS dependency packages e.g. libcairo2-dev | ||
# then put them in .github/config/ubuntu-requirements.txt, one | ||
# package per line. | ||
|