feat: Add the support for the optional route source parameter in nm provider #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #714 +/- ##
===========================================
+ Coverage 20.50% 43.29% +22.79%
===========================================
Files 10 12 +2
Lines 1478 3109 +1631
Branches 433 0 -433
===========================================
+ Hits 303 1346 +1043
- Misses 1174 1763 +589
+ Partials 1 0 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
liangwen12year
force-pushed
the
route_src
branch
3 times, most recently
from
872bb19
to
29fc8a1
Compare
liangwen12year
changed the title
|
[citest] |
liangwen12year
force-pushed
the
route_src
branch
from
29fc8a1
to
fcd758f
Compare
|
[citest] |
liangwen12year
force-pushed
the
route_src
branch
from
fcd758f
to
d2a6083
Compare
|
This PR takes part of the code from #529. |
…rovider Enhancement: Add the optional route source parameter for the nm provider Reason: In a scenario where you have a machine with multiple public IP addresses, typically due to a multi-WAN setup, the src parameter in the context of routes allows you to specify which source IP address should be used when sending packets via a specific route. This is crucial when you want to ensure that outbound traffic uses a specific IP address tied to a particular network interface, especially when dealing with multiple WAN connections. Result: Adding support for the src parameter in routes results in a more powerful and flexible network configuration capability, especially important in environments with multiple network interfaces or multiple IP addresses, it provides better control over traffic routing. Resolves: https://issues.redhat.com/browse/RHEL-3252 Signed-off-by: Wen Liang <[email protected]>
liangwen12year
force-pushed
the
route_src
branch
from
d2a6083
to
169d276
Compare
|
[citest] |
cathay4t
approved these changes
Aug 5, 2024
richm
approved these changes
Aug 5, 2024
liangwen12year
merged commit 8195188
into
linux-system-roles:main
29 of 40 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement: Add the optional route source parameter for the nm provider
Reason: In a scenario where you have a machine with multiple public IP
addresses, typically due to a multi-WAN setup, the src parameter in the
context of routes allows you to specify which source IP address should
be used when sending packets via a specific route. This is crucial when
you want to ensure that outbound traffic uses a specific IP address tied
to a particular network interface, especially when dealing with multiple
WAN connections.
Result: Adding support for the src parameter in routes results in a
more powerful and flexible network configuration capability, especially
important in environments with multiple network interfaces or multiple
IP addresses, it provides better control over traffic routing.
Resolves: https://issues.redhat.com/browse/RHEL-3252
Issue Tracker Tickets (Jira or BZ if any):