Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: role does not work on el10, aarch64 #25

Merged
merged 1 commit into from
Aug 22, 2024
Merged

feat: role does not work on el10, aarch64 #25

merged 1 commit into from
Aug 22, 2024

Conversation

richm
Copy link
Contributor

@richm richm commented Aug 20, 2024 •
edited
Loading

gfs2 support is being removed in el10.
Replacement TBD.

Role does not support aarch64

Signed-off-by: Rich Megginson [email protected]

@richm richm requested a review from andyprice August 20, 2024 22:06
@richm
Copy link
Contributor Author

richm commented Aug 20, 2024

[citest]

@richm
feat: role does not work on el10, aarch64
2e7dea6 
gfs2 support is being removed in el10.
Replacement TBD.

Role does not support aarch64

Signed-off-by: Rich Megginson <[email protected]>
@richm richm changed the title feat: role does not work on el10 feat: role does not work on el10, aarch64 Aug 21, 2024
@richm
Copy link
Contributor Author

richm commented Aug 21, 2024

[citest]

@richm
Copy link
Contributor Author

richm commented Aug 21, 2024

@spetrosi the job Get supported platforms is not working - meta/main.yml does not contain el10 - https://github.com/linux-system-roles/gfs2/pull/25/files#diff-92c74e80f0140aa012f39f58b4259dbe74401cdc9a0b84269295f480b9961809L22 - but the job adds the CentOS-Stream-10 - https://github.com/linux-system-roles/gfs2/actions/runs/10495811619/job/29082573459

##[debug]/usr/bin/bash -e /home/runner/work/_temp/8896fbe6-bd2d-4b7b-bfb3-1e3c44163f0b.sh
##[debug]Set output supported_platforms =  Fedora-39 Fedora-40 CentOS-Stream-8 CentOS-Stream-9 CentOS-Stream-10
##[debug]Finishing: Get supported platforms

running yq locally, it seems to be working
so I'm not sure what's going on here

@richm richm merged commit 044bf03 into linux-system-roles:main Aug 22, 2024
24 of 25 checks passed
@richm richm deleted the no-el10 branch August 22, 2024 13:11
@spetrosi
Copy link
Contributor

I know why, the workflow checks out the main branch, and we need to check out PR's ref and get info about memory and supported platforms from there. I'll fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyprice andyprice andyprice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richm @spetrosi @andyprice