Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic tests #611

Closed
PoignardAzur opened this issue Jun 12, 2024 · 3 comments
Closed

Add basic tests #611

PoignardAzur opened this issue Jun 12, 2024 · 3 comments

Comments

@PoignardAzur
Copy link
Contributor

Vello has test scenes, but no integration tests.

Adding tests would help Vello contributors check that their modifications don't add regressions to the crate, and help us catch hidden bugs.

As a first step, we'd want to at least add some extremely basic tests, such as checking that Vello doesn't crash when we run a sample image through the CPU shaders.

@DJMcNab
Copy link
Member

DJMcNab commented Jun 12, 2024

I'm not sure how this issue can now be actioned? I would have expected the integration tests in #439 to cover this use case.

See also #608

@PoignardAzur
Copy link
Contributor Author

Well, then just remove these tests and do another PR that adds some tests!

@PoignardAzur
Copy link
Contributor Author

But yeah, I feel a bit silly, especially since we talked about that PR an hour ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants