Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSA: Do not replace arrayvec with tinyvec #65

Closed
notgull opened this issue Dec 18, 2022 · 1 comment
Closed

PSA: Do not replace arrayvec with tinyvec #65

notgull opened this issue Dec 18, 2022 · 1 comment

Comments

@notgull
Copy link

notgull commented Dec 18, 2022

I'll open and close this issue, if nothing else than to use as precedent if anyone else wants to do this.

I tried replacing the usage of arrayvec in this crate with tinyvec, with is an alternative with no unsafe code. However, this caused a significant degradation of performance in the benchmarks for this crate. Therefore, I don't think it is a good idea to replace arrayvec with tinyvec.

@notgull notgull closed this as completed Dec 18, 2022
@RazrFalcon
Copy link
Collaborator

Thanks. I think I've tried this as well with poor results.

As for unsafe, we don't have much, except SIMD, which might be improved with #59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants