-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retrospective on the May-July 2024 roadmap #59
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI the "rendered" link in the first comment is outdated. I noticed because the conclusion had a sentence fragment that is not present in the current state of the PR. It should be https://github.com/linebender/linebender.github.io/blob/28239f4f66851e667ccde05ca51176fca64157a1/content/blog/2024-08-23-roadmap-may-2024-retro.md
Co-Authored-By: Raph Levien <[email protected]>
Thanks for the reviews, applied the fixes. It's not entirely clear to me how that RENDERED link got into the state it was previous. Fwiw, linking to a specific commit in that kind of RENDERED link is never the right behaviour because it will not be updated properly. Thanks for pointing out I had inadvertently used that format! |
Makes sense. Side question: is there a place in the GitHub UI where the rendered link is available? All I've found is navigating to "Files Changed" -> https://github.com/linebender/linebender.github.io/pull/59/files -> hamburger menu on the |
Ah, that is the process I went through to get the original URL, that explains it. The way I've found to be correct is to click on the branch name (under the PR title), then navigate to the correct file from there. But it's not ideal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Masonry is in a state of flux, however is starting to see a few exploratory users. | ||
To unblock these users, some additional important features were added outside of the roadmap, such as: | ||
|
||
- Support for embedding Masonry inside a pre-existing event loop ([xilem#417](https://github.com/linebender/xilem/pull/417)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link is a 404. I think you're referring to xilem#325?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, that link is correct
GitHub has deleted the pull request, but the change I'm referring to happened in that PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Because the account of @cfagot is still not recovered for whatever reason)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've linked to linebender/xilem@cf35300 instead.
New conclusion is good. |
Maybe this should be part of the template?
RENDERED
Current status: This is complete besides the harfruzz section, and is awaiting review