Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrospective on the May-July 2024 roadmap #59

Merged
merged 10 commits into from
Aug 24, 2024
Merged

Retrospective on the May-July 2024 roadmap #59

merged 10 commits into from
Aug 24, 2024

Conversation

DJMcNab
Copy link
Member

@DJMcNab DJMcNab commented Aug 19, 2024

RENDERED

Current status: This is complete besides the harfruzz section, and is awaiting review

Copy link

@matta matta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI the "rendered" link in the first comment is outdated. I noticed because the conclusion had a sentence fragment that is not present in the current state of the PR. It should be https://github.com/linebender/linebender.github.io/blob/28239f4f66851e667ccde05ca51176fca64157a1/content/blog/2024-08-23-roadmap-may-2024-retro.md

content/blog/2024-08-23-roadmap-may-2024-retro.md Outdated Show resolved Hide resolved
content/blog/2024-08-23-roadmap-may-2024-retro.md Outdated Show resolved Hide resolved
content/blog/2024-08-23-roadmap-may-2024-retro.md Outdated Show resolved Hide resolved
@DJMcNab
Copy link
Member Author

DJMcNab commented Aug 23, 2024

Thanks for the reviews, applied the fixes.

It's not entirely clear to me how that RENDERED link got into the state it was previous. Fwiw, linking to a specific commit in that kind of RENDERED link is never the right behaviour because it will not be updated properly. Thanks for pointing out I had inadvertently used that format!

@matta
Copy link

matta commented Aug 23, 2024

It's not entirely clear to me how that RENDERED link got into the state it was previous. Fwiw, linking to a specific commit in that kind of RENDERED link is never the right behaviour because it will not be updated properly. Thanks for pointing out I had inadvertently used that format!

Makes sense. Side question: is there a place in the GitHub UI where the rendered link is available? All I've found is navigating to "Files Changed" -> https://github.com/linebender/linebender.github.io/pull/59/files -> hamburger menu on the .md file in question -> select the "View File" menu item. But that gives me a "permalink" style URL, tied to a commit.

@DJMcNab
Copy link
Member Author

DJMcNab commented Aug 23, 2024

Ah, that is the process I went through to get the original URL, that explains it. The way I've found to be correct is to click on the branch name (under the PR title), then navigate to the correct file from there. But it's not ideal

Copy link
Contributor

@PoignardAzur PoignardAzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

content/blog/2024-08-23-roadmap-may-2024-retro.md Outdated Show resolved Hide resolved
content/blog/2024-08-23-roadmap-may-2024-retro.md Outdated Show resolved Hide resolved
content/blog/2024-08-23-roadmap-may-2024-retro.md Outdated Show resolved Hide resolved
Masonry is in a state of flux, however is starting to see a few exploratory users.
To unblock these users, some additional important features were added outside of the roadmap, such as:

- Support for embedding Masonry inside a pre-existing event loop ([xilem#417](https://github.com/linebender/xilem/pull/417)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link is a 404. I think you're referring to xilem#325?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that link is correct

GitHub has deleted the pull request, but the change I'm referring to happened in that PR.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Because the account of @cfagot is still not recovered for whatever reason)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've linked to linebender/xilem@cf35300 instead.

content/blog/2024-08-23-roadmap-may-2024-retro.md Outdated Show resolved Hide resolved
@PoignardAzur
Copy link
Contributor

New conclusion is good.

@DJMcNab DJMcNab merged commit cd8436b into main Aug 24, 2024
1 check passed
@DJMcNab DJMcNab deleted the roadmap-retro branch August 24, 2024 13:43
DJMcNab added a commit to DJMcNab/linebender.github.io that referenced this pull request Aug 24, 2024
Maybe this should be part of the template?
DJMcNab added a commit that referenced this pull request Aug 25, 2024
Which was added in #59 

Maybe it would be useful for this to be (conditionally?) part of the
template?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants