Update Channel Monitor without broadcasting transactions #3428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
yellowred
force-pushed
the
oleg_cmo_update_no_broadcast
branch
2 times, most recently
from
aa8a8f8
to
9ae5067
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3428 +/- ##
==========================================
- Coverage 89.24% 89.23% -0.01%
==========================================
Files 130 130
Lines 106912 107132 +220
Branches 106912 107132 +220
==========================================
+ Hits 95410 95602 +192
- Misses 8706 8728 +22
- Partials 2796 2802 +6 ☔ View full report in Codecov by Sentry. |
Allowing Channel Monitor to be updated without executing any commands outside ChannelMonitor. This allows reading Channel Monitor in MonitorUpdatingPersister without using broadcaster and fee estimator and broadcast claims when the node is ready for it.
yellowred
force-pushed
the
oleg_cmo_update_no_broadcast
branch
from
9ae5067
to
d767353
Compare
yellowred
commented
Nov 27, 2024
|
|
||
| /// Same as [provide_payment_preimage], but does not immediately broadcasts transactions, | ||
| /// returning them back to the caller instead. | ||
| fn provide_payment_preimage_without_broadcasting<L: Deref>( |
There was a problem hiding this comment.
@TheBlueMatt Not sure about this func. On one hand I don't want to change provide_payment_preimage, on the other -- there is clear duplicated logic. Do you think it would be better to modify provide_payment_preimage to support returning claims?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing Channel Monitor to be updated without executing any commands outside ChannelMonitor. This allows reading Channel Monitor in MonitorUpdatingPersister without using broadcaster and fee estimator and broadcast claims when the node is ready for it.