Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update Action fromAddress property to required #203

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: update Action fromAddress property to required #203

wants to merge 1 commit into from
+1 −1

Conversation

rialco
Copy link
Contributor

@rialco rialco commented Oct 24, 2023

No description provided.

mathiasmoeller
mathiasmoeller reviewed Oct 24, 2023
View reviewed changes
Copy link
Member

@mathiasmoeller mathiasmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first of all this is not a chore, this is a breaking change

mathiasmoeller
mathiasmoeller reviewed Oct 24, 2023
View reviewed changes
Copy link
Member

@mathiasmoeller mathiasmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can not do this, it's a breaking change. We can only do this internally in the Backend if we need this

@chybisov
Copy link
Member

@mathiasmoeller This won't break anything on the frontend, so if you need this go for it here so we can have the same types

@mathiasmoeller
Copy link
Member

But it could break any other partner integration. @rialco can we close this PR?

@chybisov
Copy link
Member

But it could break any other partner integration. @rialco can we close this PR?

Which one? SDK v3 is still in alpha, and v2 uses types v9

@mathiasmoeller
Copy link
Member

People using the API directly. If they don't pass the fromAddress in the Action yet it will break

@myz1237
Copy link
Contributor

myz1237 commented Jun 4, 2024

is it safe to discard it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathiasmoeller mathiasmoeller mathiasmoeller left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rialco @chybisov @mathiasmoeller @myz1237