Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the 3 from the cmake variables #588

Open
madebr opened this issue Jan 21, 2024 · 2 comments
Open

Remove the 3 from the cmake variables #588

madebr opened this issue Jan 21, 2024 · 2 comments

Comments

@madebr
Copy link
Contributor

madebr commented Jan 21, 2024

Let's remove the 3 inside the cmake configuration variables of all SDL satellite libraries.

For SDL3 satellite libraries, this incompatibility should not be an issue.

I would not remove the 2 from the SDL2 satellites as projects may depend on this.
If this is not an issue, we can still read the "2-variable" and use it as a hint.
An advantage of doing the change for 2 as well could be an uniform way of configuring SDL2 and 3 cmake projects.

wdyt?

@slouken
Copy link
Collaborator

slouken commented Jan 21, 2024

Yes, yes please!

@slouken
Copy link
Collaborator

slouken commented Jan 21, 2024

I don't think we need to use the 2 variable as a hint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants