-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NES games getting TOSEC titles while boxart is No-Intro names #1496
Comments
The publisher names are coming from TOSEC. These were added a while ago in RobLoach/libretro-dats#84 , but cause issues with the naming scheme, as you can see here. Think we should remove TOSEC for NES? Realized we didn't merge the TOSEC thumbs libretro-thumbnails/Nintendo_-_Nintendo_Entertainment_System#86 . |
But, but... as I remember, the merging during database creation is done in priority order, where no-intro should have higher prio. So in theory, if the checksum matches no-intro, name should also be retrieved from there? Let's see what can be done... |
I did a brief check, but tosec seems to have different checksums, so with the previous database, those dumps would simply not be recognized. |
Thanks for testing. Perhaps in the conversion from TOSEC to libretro DATs, we try to strip some more of the publisher names. The TOSEC naming scheme is so gross lol https://github.com/RobLoach/libretro-dats/blob/master/index.js#L143-L188 |
This post from reddit explains it pretty well:
As best I can tell, it seems to be pulling the names from the TOSEC NES database, which isn't a problem in and of itself, but the scanned games don't match the thumbnails, which are based on No-Intro titles, AFAIK.
The text was updated successfully, but these errors were encountered: