-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for go1.23 #1034
base: master
Are you sure you want to change the base?
Support for go1.23 #1034
Conversation
We have internal dependency on testing package that was changed in go version 1.23 Signed-off-by: Paul Gaiduk <[email protected]>
Signed-off-by: Paul Gaiduk <[email protected]>
Should be irrelevant once #1037 is merged and escript is deprecated |
@uncleDecart you're getting rid of the whole escript directory, right? |
Yes, we merge my PR, move tests to NeoEden and then remove all the old tests completely. It'll take time to do so, though |
@uncleDecart I just had a look at #1037 and you are keeping UPD: oh, you're only gonna get rid of it, once NeoEden tests are merged, right? |
Right, would be barbaric to just remove what we have before we create new |
@uncleDecart I guess we can close this one as not relevant anymore, right? |
@uncleDecart sorry, I just read the previous discussion and now I think that we should rather merge this PR, since NeoEden tests will take a looong time to complete once they are merged however we call remove both |
We will have to bump version in all the GHA files + in go.mod itself if we want to merge this |
no, we can keep using 1.22. |
Keeping up with the good tradition to use go's internal APIs and update the dependencies by hand 😄
Doesn't really need to be merged until we move to go 1.23 in go.mod, but can be useful for people using 1.23 locally.