Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocrafting system rework #16

Open
lewark opened this issue Nov 25, 2022 · 2 comments
Open

Autocrafting system rework #16

lewark opened this issue Nov 25, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@lewark
Copy link
Owner

lewark commented Nov 25, 2022

The current implementation of autocrafting can be improved. Currently, the following tickets are associated:

A partial rewrite of that component may be necessary to resolve them. Plus, there are these lingering issues:

@lewark lewark added the bug Something isn't working label Nov 25, 2022
@lewark lewark closed this as completed Nov 26, 2022
@lewark lewark reopened this Nov 28, 2022
@lewark
Copy link
Owner Author

lewark commented Nov 28, 2022

To fix #28, it may be necessary to find a complete solution for the requested item and then queue all of the necessary tasks at once. The current implementation of CraftManager is limited to one recipe per item type so under this restriction the algorithm may be straightforward. However, supporting fallback recipes would remove this simplification.

The items may also need to be marked as reserved somehow so that a second autocrafting task does not interfere with the first. The current system where tasks are added iteratively could be preserved if extra materials that are currently being crafted are counted. However, I wonder if it would be better to solve for the recipe using a recursive function, like how the early versions of this software did, instead of through the task system.

@lewark lewark pinned this issue Dec 13, 2022
@lewark lewark changed the title Redundant crafting Crafting system rework Dec 14, 2022
@lewark lewark added enhancement New feature or request and removed bug Something isn't working labels Dec 14, 2022
@lewark
Copy link
Owner Author

lewark commented Dec 14, 2022

Converted this ticket into an overview of all autocrafting-related issues.

@lewark lewark changed the title Crafting system rework Autocrafting system rework Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant