Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark is easy to misuse #92

Open
rawbby opened this issue Aug 27, 2021 · 1 comment
Open

Benchmark is easy to misuse #92

rawbby opened this issue Aug 27, 2021 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@rawbby
Copy link
Contributor

rawbby commented Aug 27, 2021

The main parameter beside resolution is the steps parameter.
This indicates (for me at least) that as you make more steps the benchmark is more meaningful.

That is somehow true. But this also highly depends on the resolution.
E.g.:

  1. You benchmark with a resolution of 4048 and 1000 steps. The result of the benchmark is 400 Mlups.

Basically you told the benchmark to calculate 4,048 Nodes * 4,048 Nodes * 1,000 Steps = 16,386,304,000 Nodes
The benchmark took 16,386,304,000 Nodes / 400,000,000 lups = ~41 Seconds

  1. You benchmark with a resolution of 16 and 1000 steps. The result of the benchmark is 350 Mlups.

Basically you told the benchmark to calculate 16 Nodes * 16 Nodes * 1,000 Steps = 256,000 Nodes
The benchmark took 256,000 Nodes / 350,000,000 lups = ~0.0007314 Seconds

There one big issue in comparing these two benchmarks:

  • The time the second benchmark took is so short that you would say it is not accurate at all. There is just too much noise in the performance of a GPU for such a short benchmark to be accurate
  • On the other hand the first benchmark seems much more accurate.

What I described is not a Bug but it leads the user to misuse the api.
I would consider to either change the benchmark parameter to Seconds or to TotalNodes (to process).

@rawbby
Copy link
Contributor Author

rawbby commented Aug 27, 2021

A Seconds parameter would make the benchmark also more useful for automation as it is somehow uncomfortable to run a process that takes an unclear amount of time.

@Olllom Olllom added the help wanted Extra attention is needed label Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants