Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Proper tests for Equilibrium Pressure Outlet #217

Open
PhiSpel opened this issue Aug 16, 2024 · 0 comments
Open

[Feature]: Proper tests for Equilibrium Pressure Outlet #217

PhiSpel opened this issue Aug 16, 2024 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@PhiSpel
Copy link
Contributor

PhiSpel commented Aug 16, 2024

Contact Details

No response

Is your proposal related to a problem?

Currently, we do not have a test for EquilibriumOutletP with low enough tolerances.

Describe the solution you'd like

Lower the tolerances by giving the simulation time to reach steady state

Describe alternatives you've considered

Do fewer time steps to a point where an analytical solution should be acchieved

Additional context

  1. test_equilibrium_outlet_p_algorithm does only one timestep, but with a high relative tolerance
  2. test_equilibrium_pressure_outlet does 30 timesteps, but with an obstacle which itself induces oscillations
@PhiSpel PhiSpel added enhancement New feature or request bug Something isn't working labels Aug 16, 2024
@PhiSpel PhiSpel changed the title [Feature]: Propert tests for Equilibrium Pressure Outlet [Feature]: Proper tests for Equilibrium Pressure Outlet Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant