Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and Restructure Methods in New Flow ABC Class #169

Open
1 task
McBs opened this issue Jul 31, 2024 · 2 comments
Open
1 task

Review and Restructure Methods in New Flow ABC Class #169

McBs opened this issue Jul 31, 2024 · 2 comments
Assignees
Labels
usability Issues and/requests regarding usabilities

Comments

@McBs
Copy link
Contributor

McBs commented Jul 31, 2024

All methods from the old Lattice class have been transferred to the new Flow ABC class. We need to review and possibly restructure these methods to ensure they are logically organized and adhere to our coding standards.

Edit by @PhiSpel:

  • When you're done with this, do make sure to reactivate test_collision_fixpoint_2x_MRT
@McBs McBs added the usability Issues and/requests regarding usabilities label Jul 31, 2024
@McBs McBs self-assigned this Jul 31, 2024
@PhiSpel
Copy link
Contributor

PhiSpel commented Aug 1, 2024

Some, such as lattice.einsum, should be removed. See also #111

Edit: Done in #241

@PhiSpel
Copy link
Contributor

PhiSpel commented Aug 16, 2024

lattice methods such as rho(f), u(f), entropy(f), etc. could be stored separately so that they can be accessed by tests without creating a Flow object. These methods do not require Flow-specific attributes, except sometimes the stencil weights.

  • When you're done with this, do make sure to reactivate test_collision_fixpoint_2x_MRT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability Issues and/requests regarding usabilities
Projects
None yet
Development

No branches or pull requests

2 participants