Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass custom marshaller to buffered client. #29

Open
makasim opened this issue Sep 16, 2024 · 2 comments
Open

Pass custom marshaller to buffered client. #29

makasim opened this issue Sep 16, 2024 · 2 comments

Comments

@makasim
Copy link
Contributor

makasim commented Sep 16, 2024

I am evaluating the replacement of the official fluent client with your package. One thing that is missing is the ability to provide a custom marshaller for the message. I want to convert json bytes to msgpack bytes directly (without marshal\unmarshal) (https://github.com/makasim/jsontomsgp).

I can provide a PR, just want to know if the project is still maintained and PR would be accepted.

@lestrrat
Copy link
Collaborator

@makasim Yeah, though it's not being actively developed but I haven't abandoned it.

wrt to your actual feature request, I'm not entirely sure if it fits in a fluent client, but I guess I don't know enough to make a decision at this point, so PoCs/pseudocode/testcases are welcome

@makasim
Copy link
Contributor Author

makasim commented Sep 17, 2024

Thank you for your reply. I need a way to pass my own marshaller to the client, the rest would be implemented outside the library. Just giving some context, not that important.

I'll send MR later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants