Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: ledger-report -- no need for font-lock ... added level of complexity. #285

Open
lawlist opened this issue Jan 12, 2021 · 0 comments

Comments

@lawlist
Copy link

lawlist commented Jan 12, 2021

The following are just some suggestions. I already made the changes in my own setup. Please feel free to incorporate or simply close out this suggestion/issue as deemed approrpiate.

From virtually day one, I learned to choose one or the other: text-properties in the buffer or use font-lock. ledger-report-mode uses both, which is not necessary (in my opinion). ansi-color-apply can be made into a new function that applies the face property instead of the fl-face-property. report--cmd-needs-links-p can be rewritten to avoid using font-lock.

So that we are not dealing with modifying ansi-color-faces-vector (or the faces that it uses) and ansi-color-names-vector, those can be brought over to ledger-report-mode for easy modification, and the variable ansi-color-map incorporating ansi-color-make-color-map based on the aforementioned variables can be ported over to ledger-report-mode as well. Consider adding a note to the doc-string(s) indicating which faces of the ansi-color-faces-vector are not used by the ledger executable -- see report.cc at the section ...fn_ansify_if(call_scope_t....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant