You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The following are just some suggestions. I already made the changes in my own setup. Please feel free to incorporate or simply close out this suggestion/issue as deemed approrpiate.
From virtually day one, I learned to choose one or the other: text-properties in the buffer or use font-lock. ledger-report-mode uses both, which is not necessary (in my opinion). ansi-color-apply can be made into a new function that applies the face property instead of the fl-face-property. report--cmd-needs-links-p can be rewritten to avoid using font-lock.
So that we are not dealing with modifying ansi-color-faces-vector (or the faces that it uses) and ansi-color-names-vector, those can be brought over to ledger-report-mode for easy modification, and the variable ansi-color-map incorporating ansi-color-make-color-map based on the aforementioned variables can be ported over to ledger-report-mode as well. Consider adding a note to the doc-string(s) indicating which faces of the ansi-color-faces-vector are not used by the ledger executable -- see report.cc at the section ...fn_ansify_if(call_scope_t....
The text was updated successfully, but these errors were encountered:
The following are just some suggestions. I already made the changes in my own setup. Please feel free to incorporate or simply close out this suggestion/issue as deemed approrpiate.
From virtually day one, I learned to choose one or the other: text-properties in the buffer or use font-lock.
ledger-report-mode
uses both, which is not necessary (in my opinion).ansi-color-apply
can be made into a new function that applies theface
property instead of thefl-face-property
.report--cmd-needs-links-p
can be rewritten to avoid using font-lock.So that we are not dealing with modifying
ansi-color-faces-vector
(or the faces that it uses) andansi-color-names-vector
, those can be brought over toledger-report-mode
for easy modification, and the variableansi-color-map
incorporatingansi-color-make-color-map
based on the aforementioned variables can be ported over toledger-report-mode
as well. Consider adding a note to the doc-string(s) indicating which faces of theansi-color-faces-vector
are not used by theledger
executable -- seereport.cc
at the section...fn_ansify_if(call_scope_t...
.The text was updated successfully, but these errors were encountered: