-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The @import rule does not properly import the requested file #402
Comments
Some level of functionality is targeted for ruby |
@robocoder can you elaborate? I can confirm this is an issue and that @steve-todorov's fix does indeed work, but I'm not sure why it wouldn't be integrated into the package as-is. |
Ruby sass is the reference implementation, not libsass. |
Should this be reported to http://sass-compatibility.github.io/ ?? |
I understand you're trying to follow the ruby implementation as close as possible. I must say, however, this feature is sometimes a serious deal breaker. Imagine you have a project, which manages it's resources using bower. Now in bower you have a few dependencies like I'm really surprised they haven't back-ported this feature to ruby yet. Anyway, I hope you reconsider and make an exception for this feature. It could be a long time until they release the official v4.0 and even then it's not entirely sure if they would have implemented this in the ruby version. |
I don't know if it's the ideal solution, but for anyone looking for a quick fix, I just override the Compile class in my application and make sure it takes precedence in composer's autoload. Something like:
|
it's still a 'problem', right? |
As far as I'm aware - yes it is. I've switched to webpack & angular since and haven't needed this anymore. If you're using symfony you can try generating a manifest and setting the path in the assets config. |
Proposal:
Question:
|
I propose to append to the compiler an internal property Then the working is untouched, but you can make the Compiler to import css files, as demanded here (accepting they are parsed as SassScript) This can go with an option for |
The
@import
rule in SASS can be used in two ways:@import: url(url)
when compiled.Here is a link explaining what I'm talking about. Some important links from there:
@import
rule works.In the current version of
scssphp
the@import
rule will result in the following compiled css:instead of actually importing the content of the
import_me
file.After digging through the source code of
scssphp
I found out the solution is quite simple. One should only append$url.'.css'
to the Compiler.php#L3218. Afterwards everything should work as expected in both scenarios when using@import
.The text was updated successfully, but these errors were encountered: