Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: IPNetwork.Parse(ReadOnlySpan<char>) #79

Open
Bond-009 opened this issue Oct 15, 2019 · 4 comments
Open

Feature request: IPNetwork.Parse(ReadOnlySpan<char>) #79

Bond-009 opened this issue Oct 15, 2019 · 4 comments

Comments

@Bond-009
Copy link

Most if not all Parse methods in netstandard2.1 accept ReadOnlySpan<char>

@lduchosal
Copy link
Owner

Dear Bond-009,

Thanks for your feedback. I'll have a look at this if time permits.

@billpg
Copy link
Contributor

billpg commented Dec 21, 2022

Does this need to be anything more than converting to a string and calling through to Parse(string)?

@lduchosal
Copy link
Owner

@billpg : The other way around. We may code Parse to use ROS and call it from Parse(string ..) string.AsSpan()..,.

This may give a direction

https://blog.ndepend.com/improve-c-code-performance-with-spant/

Span/ReadOnlySpan are special API that required heavy runtime modifications to offer improvements in very high performance critical scenarios. Not everyone needs its power but for those that needs it, it is a game changer.

I do agree with this article conclusion, do we really need it ? may be if time permits

@billpg
Copy link
Contributor

billpg commented Dec 22, 2022

Gotcha. The task is to refactor the various Parse functions to use ROSc and add string functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants