Cleanup codebase

[lchrusciel]

We should try some tool that will help to maintain clean code base.

E.g. https://github.com/Symplify/EasyCodingStandard

[antkaz]

I can advise https://github.com/slevomat/coding-standard

[lchrusciel]

Isn't it part of EsayCodingStandard?

Anyway, I have started to work on ECS integration in #137, but maybe I will give a try to Slevomat. Also, feel free to help me :)

[antkaz]

Not quite.
I am not familiar with EasyCodingStandard, but judging by the documentation, it uses the rules of the PHP_CodeSniffer.

Levomat also uses code-sniffer, but it also contains many additional rules (they also exist in phpstan) that can be customized for your project.

In my project, I started using PHP_CodeSniffer, but then I added the Slevomat rules and configured them as necessary (which does not allow PHP_CodeSniffer to do).

[lchrusciel]

I truly believe that ECS is just a wrapper around Slevomat, as there are a lot of Slevomat rules used internally like here: https://github.com/Symplify/EasyCodingStandard/blob/master/config/clean-code.yml#L2-L12

Still, anything that will make the code better by automatization is good for me :)

[stefandoorn]

What about the Sylius Coding Standard rules for PHPStan?

[antkaz]

Really! Looked bad)

https://github.com/Symplify/EasyCodingStandard/blob/master/composer.json#L22