By jove, I think I've done it #244
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
World->IWorldwas the last piece. The worldgen being threaded meant that by trying to read/write to ServerWorld instead of the pseudo worldgen abstract region, it was locking up, two threads waiting on each other.Behold, success:
Commands are still inoperable, have no idea if the wireframe rendering code needs its own updates, I didn't even mess with those last time. Not critical to my own build path, though certainly handy.
The literal BS feature/structure registration I did having worked without any issue is a huge load off my conscience as it means I don't need to try and figure out what the hell COG does or how structures work. Did the literal bare bones required for the game to accept things at compile-time, hoping I didn't have to go deeper, worked out.
Now I can start on updating for 1.19, which hopefully is just updating mappings for the most part, though I'm sure a few other oddities abound as well, eg. the world now extends down to y=-64.