-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump forge-std #3344
base: main
Are you sure you want to change the base?
chore: bump forge-std #3344
Conversation
🦋 Changeset detectedLatest commit: 07ab863 The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
9cdbfde
to
6566ec4
Compare
given that the gas reports also changed, I suspect this caused a small bytecode change, prob the compiler taking a new path (even though we're not importing forge-std anywhere except in tests/scripts) |
Co-authored-by: Kevin Ingersoll <[email protected]>
Fixes #2824
Had to also update the getStoreLogs test snapshot because the system's address changed for some reason. My current theory is that the compiler is just acting weird because of the new forge-std version (when compiling everything the bytecode of the system changes). Haven't been able to fully isolate the issue tho, but probably not really important?