Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test to check fork after key loaded with PIN in URI only #322

Open
simo5 opened this issue Dec 1, 2023 · 1 comment
Open

Add test to check fork after key loaded with PIN in URI only #322

simo5 opened this issue Dec 1, 2023 · 1 comment
Assignees
@The-Mule
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed tests

Comments

@simo5
Copy link
Member

simo5 commented Dec 1, 2023

Although we do test reloading keys after fork in tests/tfork, we should probably add a test that specifically test with teh token configured w/o apin and instead pin only passed via URI.

Follow up to #316
@simo5 simo5 added enhancement New feature or request tests good first issue Good for newcomers help wanted Extra attention is needed labels Dec 1, 2023
@sahanaprasad07 sahanaprasad07 self-assigned this Dec 1, 2023
@sahanaprasad07 sahanaprasad07 removed their assignment Mar 16, 2024
@The-Mule The-Mule self-assigned this Oct 29, 2024
@The-Mule
Copy link
Collaborator

Note to myself: PIN in URI should always take precedence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@The-Mule The-Mule

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@simo5 @The-Mule @sahanaprasad07