Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default IdP when multiple IdPs are configured #41

Open
vittala opened this issue Nov 9, 2020 · 1 comment
Open

Default IdP when multiple IdPs are configured #41

vittala opened this issue Nov 9, 2020 · 1 comment

Comments

@vittala
Copy link

vittala commented Nov 9, 2020

In cases where there are multiple IdPs, it would be nice to be able to specify a default IdP entity ID to use when one is not explicitly set.

Currently, am_first_idp doesn't always return the first IdP specified in the configuration. It calls g_hash_table_get_keys to get the server keys and I believe the ordering of the result is not defined.

Would it be possible to have a MellonDefaultIdP option, or can this only be done using a discovery URL?

Thanks
Vittal

@thijskh
Copy link

thijskh commented May 11, 2021

Indeed you could add such a config option. Alternatively, maybe simpler you could make the ordering defined and document what it is (e.g. "When multiple IdPs are configured, Mellon will pick the first IdP listed as its default."). This is less flexible but does not add yet another thing to configure. In any case, best is to start with a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants