Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend linting to all .md files ? #222

Open
arhimede opened this issue Oct 25, 2024 · 3 comments · May be fixed by #236
Open

Extend linting to all .md files ? #222

arhimede opened this issue Oct 25, 2024 · 3 comments · May be fixed by #236
Assignees
@froschdesign
Labels
Enhancement

Comments

@arhimede
Copy link
Member

Feature Request

Q A
New Feature yes

Summary

Currently , the blog .md files and authors.md files are not checked.
Do we want to extend the check to all .md files ?
@froschdesign
Copy link
Member

froschdesign commented Nov 18, 2024 •
edited
Loading

We should definitely do this!

The rule for checking the line length must be ignored:

.markdownlint.json

{
    "default": true,
    "MD013": false
}

https://github.com/DavidAnson/markdownlint/blob/v0.32.1/doc/md013.md

@arhimede
Copy link
Member Author

@Xerkus any idea why the continuous integration is running linting only on README file ?
example this one
https://github.com/laminas/getlaminas.org/actions/runs/11499789946/job/32008552667

@gsteel
Copy link
Member

gsteel commented Nov 19, 2024

The CI action has 1 job for the readme and 1 job for anything in /doc or /docs - it'd be better to run the linter in a specific job here using a standalone action such as https://github.com/marketplace/actions/markdownlint-cli2-action

@Jurj-Bogdan Jurj-Bogdan linked a pull request Nov 28, 2024 that will close this issue
Open
@arhimede arhimede linked a pull request Nov 28, 2024 that will close this issue
added linting action and fixed linting errors #236
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@froschdesign froschdesign

Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added linting action and fixed linting errors Jurj-Bogdan/getlaminas.org
3 participants
@froschdesign @gsteel @arhimede