Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If you are alone bots will appear in battle royale mode #965

Merged
merged 1 commit into from
Sep 26, 2024
Merged

If you are alone bots will appear in battle royale mode #965

merged 1 commit into from
Sep 26, 2024

Conversation

manucamejo
Copy link
Collaborator

@manucamejo manucamejo commented Sep 26, 2024 •
edited
Loading

Motivation

We want to play without bots if you are playing against another player.
But if you are alone, you should play with bots.
Closes #963

Summary of changes

  • Add bot names.
  • Check how many players are in the match.
  • Call bots if the number of players is one.

How to test it?

Play in battle royale mode alone and with another player.

Checklist

  • Tested the changes locally.
  • Reviewed the changes on GitHub, line by line.
  • This change requires new documentation.
    • Documentation has been added/updated.

@tvillegas98 tvillegas98 merged commit fe032c9 into main Sep 26, 2024
1 check passed
@tvillegas98 tvillegas98 deleted the enable-bots-only-when-playing-alone branch September 26, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvillegas98 tvillegas98 tvillegas98 approved these changes

@Nico-Sanchez Nico-Sanchez Nico-Sanchez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Battle mode should have bots only if you are alone
3 participants
@manucamejo @Nico-Sanchez @tvillegas98