Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial progress for multiple packages #123

Merged
merged 5 commits into from
May 10, 2024
Merged

initial progress for multiple packages #123

merged 5 commits into from
May 10, 2024

Conversation

edg-l
Copy link
Collaborator

@edg-l edg-l commented May 7, 2024

The project builder now allows to have a binary and a library at the same time via a main.con and lib.con.

I also changed the way file discovery is done, it starts from lib.con and main.con and via the "mod <name>" declarations it imports and parses the requested modules

# mylib.con
mod mylib {
    mod hello; // this includes the file hello.con to the compilation process, maybe we should use a diferent syntax?

    pub fn mylib() -> i32 {
        return 0;
    }
}

I think with this we can start to structure a stdlib

Copy link

github-actions bot commented May 7, 2024

Benchmarking factorial

Compiling factorial (factorial.con)
Finished release in 30.662722ms
Running 5000000 iterations
Using input value: 20
Concrete Result = 2432902008176640000 Time taken : 59.28 ms
Rust Result = 2432902008176640000 Time taken : 60.06 ms

Benchmarking fib

Compiling fib (fib.con)
Finished release in 27.270584ms
Running 5000 iterations
Using input value: 20
Concrete Result = 6765 Time taken : 136.08 ms
Rust Result = 6765 Time taken : 85.23 ms

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 85 lines in your changes are missing coverage. Please review.

Project coverage is 61.74%. Comparing base (56a8221) to head (b19ba57).

Files Patch % Lines
crates/concrete_driver/src/lib.rs 0.00% 69 Missing ⚠️
crates/concrete_check/src/lib.rs 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
+ Coverage   61.71%   61.74%   +0.02%     
==========================================
  Files          25       25              
  Lines        4532     4530       -2     
==========================================
  Hits         2797     2797              
+ Misses       1735     1733       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@juanbono juanbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments. I think it needs some docs

@juanbono juanbono added this pull request to the merge queue May 10, 2024
Merged via the queue into main with commit 055c734 May 10, 2024
6 checks passed
@juanbono juanbono deleted the multiple_packages branch May 10, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants