Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactor with BlockExt #939

Merged
merged 16 commits into from
Nov 25, 2024
Merged

Small refactor with BlockExt #939

merged 16 commits into from
Nov 25, 2024

Conversation

edg-l
Copy link
Collaborator

@edg-l edg-l commented Nov 22, 2024

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@edg-l edg-l marked this pull request as ready for review November 22, 2024 12:18
Copy link

github-actions bot commented Nov 22, 2024

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 10.908 ± 0.382 10.433 11.237 8.10 ± 0.28
cairo-native (embedded AOT) 3.305 ± 0.009 3.297 3.324 2.45 ± 0.01
cairo-native (embedded JIT using LLVM's ORC Engine) 3.133 ± 0.024 3.110 3.180 2.33 ± 0.02
cairo-native (standalone AOT with -march=native) 1.347 ± 0.001 1.346 1.349 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 10.584 ± 0.216 10.419 11.124 136.55 ± 2.85
cairo-native (embedded AOT) 2.867 ± 0.015 2.851 2.891 36.99 ± 0.26
cairo-native (embedded JIT using LLVM's ORC Engine) 2.666 ± 0.011 2.645 2.685 34.39 ± 0.21
cairo-native (standalone AOT with -march=native) 0.078 ± 0.000 0.077 0.079 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 4.109 ± 0.023 4.071 4.145 17.00 ± 0.10
cairo-native (embedded AOT) 3.040 ± 0.016 3.010 3.067 12.58 ± 0.07
cairo-native (embedded JIT using LLVM's ORC Engine) 2.972 ± 0.011 2.958 2.998 12.30 ± 0.05
cairo-native (standalone AOT with -march=native) 0.242 ± 0.000 0.241 0.243 1.00

Copy link

github-actions bot commented Nov 22, 2024

Benchmark results Main vs HEAD.

Command Mean [s] Min [s] Max [s] Relative
base factorial_2M.cairo (JIT) 3.210 ± 0.017 3.182 3.238 1.00
base factorial_2M.cairo (AOT) 3.369 ± 0.018 3.340 3.402 1.05 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head factorial_2M.cairo (JIT) 3.200 ± 0.027 3.161 3.248 1.00
head factorial_2M.cairo (AOT) 3.382 ± 0.018 3.355 3.412 1.06 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base fib_2M.cairo (JIT) 2.744 ± 0.018 2.712 2.776 1.00
base fib_2M.cairo (AOT) 2.952 ± 0.016 2.937 2.983 1.08 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head fib_2M.cairo (JIT) 2.740 ± 0.020 2.711 2.783 1.00
head fib_2M.cairo (AOT) 2.946 ± 0.012 2.929 2.965 1.07 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base logistic_map.cairo (JIT) 3.048 ± 0.028 3.008 3.093 1.00
base logistic_map.cairo (AOT) 3.138 ± 0.024 3.090 3.170 1.03 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head logistic_map.cairo (JIT) 3.033 ± 0.023 2.985 3.072 1.00
head logistic_map.cairo (AOT) 3.102 ± 0.014 3.084 3.129 1.02 ± 0.01

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 82.10117% with 184 lines in your changes missing coverage. Please review.

Project coverage is 82.61%. Comparing base (fb28495) to head (ed79976).

Files with missing lines Patch % Lines
src/libfuncs/starknet.rs 19.64% 90 Missing ⚠️
src/libfuncs/bounded_int.rs 9.09% 50 Missing ⚠️
src/libfuncs/cast.rs 32.00% 17 Missing ⚠️
src/libfuncs/circuit.rs 93.97% 5 Missing ⚠️
src/libfuncs/enum.rs 50.00% 5 Missing ⚠️
src/libfuncs/int_range.rs 44.44% 5 Missing ⚠️
src/types/starknet.rs 0.00% 3 Missing ⚠️
src/types/enum.rs 50.00% 2 Missing ⚠️
src/libfuncs/array.rs 99.04% 1 Missing ⚠️
src/libfuncs/felt252.rs 97.43% 1 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #939      +/-   ##
==========================================
+ Coverage   82.47%   82.61%   +0.14%     
==========================================
  Files         117      117              
  Lines       34378    33477     -901     
==========================================
- Hits        28354    27658     -696     
+ Misses       6024     5819     -205     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@edg-l edg-l added the review-ready A PR that is ready for review label Nov 22, 2024
@edg-l edg-l added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit 2b945fc Nov 25, 2024
32 checks passed
@edg-l edg-l deleted the small_refactor branch November 25, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-ready A PR that is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants