Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove panics in arch.rs #926

Merged
merged 5 commits into from
Nov 20, 2024
Merged

Remove panics in arch.rs #926

merged 5 commits into from
Nov 20, 2024

Conversation

FrancoGiachetta
Copy link
Contributor

@FrancoGiachetta FrancoGiachetta commented Nov 15, 2024

  • src/arch.rs

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

Copy link

github-actions bot commented Nov 15, 2024

✅ Code is now correctly formatted.

Copy link

github-actions bot commented Nov 15, 2024

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 10.879 ± 0.172 10.724 11.317 8.07 ± 0.13
cairo-native (embedded AOT) 3.384 ± 0.039 3.325 3.461 2.51 ± 0.03
cairo-native (embedded JIT using LLVM's ORC Engine) 3.198 ± 0.045 3.143 3.278 2.37 ± 0.03
cairo-native (standalone AOT with -march=native) 1.348 ± 0.001 1.346 1.351 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.238 ± 0.271 10.714 11.472 143.85 ± 6.68
cairo-native (embedded AOT) 2.909 ± 0.038 2.871 2.991 37.24 ± 1.56
cairo-native (embedded JIT using LLVM's ORC Engine) 2.733 ± 0.032 2.697 2.793 34.98 ± 1.45
cairo-native (standalone AOT with -march=native) 0.078 ± 0.003 0.077 0.097 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 4.376 ± 0.031 4.345 4.455 18.07 ± 0.13
cairo-native (embedded AOT) 3.186 ± 0.034 3.132 3.250 13.16 ± 0.14
cairo-native (embedded JIT using LLVM's ORC Engine) 3.072 ± 0.037 3.025 3.126 12.69 ± 0.15
cairo-native (standalone AOT with -march=native) 0.242 ± 0.000 0.242 0.242 1.00

Copy link

github-actions bot commented Nov 15, 2024

Benchmark results Main vs HEAD.

Command Mean [s] Min [s] Max [s] Relative
head factorial_2M.cairo (JIT) 3.276 ± 0.040 3.216 3.344 1.02 ± 0.02
base factorial_2M.cairo (JIT) 3.224 ± 0.051 3.155 3.334 1.00
head factorial_2M.cairo (AOT) 3.330 ± 0.029 3.308 3.403 1.03 ± 0.02
base factorial_2M.cairo (AOT) 3.332 ± 0.022 3.305 3.377 1.03 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
head fib_2M.cairo (JIT) 2.679 ± 0.018 2.655 2.708 1.00
base fib_2M.cairo (JIT) 2.720 ± 0.037 2.681 2.784 1.02 ± 0.02
head fib_2M.cairo (AOT) 2.905 ± 0.018 2.876 2.941 1.08 ± 0.01
base fib_2M.cairo (AOT) 2.900 ± 0.031 2.839 2.943 1.08 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
head logistic_map.cairo (JIT) 3.028 ± 0.042 2.969 3.092 1.01 ± 0.02
base logistic_map.cairo (JIT) 3.001 ± 0.036 2.969 3.074 1.00
head logistic_map.cairo (AOT) 3.033 ± 0.016 2.999 3.053 1.01 ± 0.01
base logistic_map.cairo (AOT) 3.063 ± 0.038 3.021 3.135 1.02 ± 0.02

@edg-l edg-l added this pull request to the merge queue Nov 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 19, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.89%. Comparing base (5b9f6ff) to head (db39316).

Files with missing lines Patch % Lines
src/arch.rs 40.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #926   +/-   ##
=======================================
  Coverage   82.89%   82.89%           
=======================================
  Files         120      120           
  Lines       34277    34277           
=======================================
  Hits        28414    28414           
  Misses       5863     5863           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@edg-l edg-l added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit 3830367 Nov 20, 2024
30 checks passed
@edg-l edg-l deleted the rm-unwraps-arch branch November 20, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants