-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coalesce all compatible no-op libfuncs into a single function. #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azteca1998
requested review from
edg-l,
igaray,
jrchatruc,
entropidelic,
fmoletta,
Oppen and
pefontana
as code owners
November 13, 2024 17:35
Benchmarking resultsBenchmark for program
|
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
11.073 ± 0.402 | 10.537 | 11.521 | 8.22 ± 0.30 |
cairo-native (embedded AOT) |
3.317 ± 0.016 | 3.294 | 3.349 | 2.46 ± 0.01 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.142 ± 0.022 | 3.105 | 3.172 | 2.33 ± 0.02 |
cairo-native (standalone AOT with -march=native) |
1.348 ± 0.001 | 1.346 | 1.349 | 1.00 |
Benchmark for program fib_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
10.654 ± 0.235 | 10.501 | 11.311 | 137.31 ± 3.04 |
cairo-native (embedded AOT) |
2.869 ± 0.011 | 2.849 | 2.884 | 36.98 ± 0.17 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2.684 ± 0.010 | 2.672 | 2.699 | 34.59 ± 0.15 |
cairo-native (standalone AOT with -march=native) |
0.078 ± 0.000 | 0.077 | 0.078 | 1.00 |
Benchmark for program logistic_map
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
4.179 ± 0.030 | 4.149 | 4.238 | 17.25 ± 0.13 |
cairo-native (embedded AOT) |
3.052 ± 0.027 | 3.025 | 3.102 | 12.60 ± 0.11 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2.980 ± 0.010 | 2.965 | 2.996 | 12.30 ± 0.04 |
cairo-native (standalone AOT with -march=native) |
0.242 ± 0.000 | 0.242 | 0.243 | 1.00 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #919 +/- ##
==========================================
+ Coverage 82.38% 82.46% +0.08%
==========================================
Files 122 117 -5
Lines 34623 34392 -231
==========================================
- Hits 28523 28362 -161
+ Misses 6100 6030 -70 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Benchmark results Main vs HEAD.
|
JulianGCalderon
previously approved these changes
Nov 14, 2024
edg-l
previously approved these changes
Nov 19, 2024
JulianGCalderon
previously approved these changes
Nov 20, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Nov 20, 2024
azteca1998
dismissed stale reviews from JulianGCalderon and edg-l
via
November 20, 2024 18:03
3f43ed3
edg-l
approved these changes
Nov 21, 2024
JulianGCalderon
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist