Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coalesce all compatible no-op libfuncs into a single function. #919

Merged
merged 8 commits into from
Nov 21, 2024

Conversation

azteca1998
Copy link
Collaborator

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@azteca1998 azteca1998 linked an issue Nov 13, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Nov 13, 2024

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.073 ± 0.402 10.537 11.521 8.22 ± 0.30
cairo-native (embedded AOT) 3.317 ± 0.016 3.294 3.349 2.46 ± 0.01
cairo-native (embedded JIT using LLVM's ORC Engine) 3.142 ± 0.022 3.105 3.172 2.33 ± 0.02
cairo-native (standalone AOT with -march=native) 1.348 ± 0.001 1.346 1.349 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 10.654 ± 0.235 10.501 11.311 137.31 ± 3.04
cairo-native (embedded AOT) 2.869 ± 0.011 2.849 2.884 36.98 ± 0.17
cairo-native (embedded JIT using LLVM's ORC Engine) 2.684 ± 0.010 2.672 2.699 34.59 ± 0.15
cairo-native (standalone AOT with -march=native) 0.078 ± 0.000 0.077 0.078 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 4.179 ± 0.030 4.149 4.238 17.25 ± 0.13
cairo-native (embedded AOT) 3.052 ± 0.027 3.025 3.102 12.60 ± 0.11
cairo-native (embedded JIT using LLVM's ORC Engine) 2.980 ± 0.010 2.965 2.996 12.30 ± 0.04
cairo-native (standalone AOT with -march=native) 0.242 ± 0.000 0.242 0.243 1.00

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 80.12422% with 32 lines in your changes missing coverage. Please review.

Project coverage is 82.46%. Comparing base (5e60089) to head (3f43ed3).

Files with missing lines Patch % Lines
src/libfuncs/bounded_int.rs 0.00% 11 Missing ⚠️
src/libfuncs/box.rs 0.00% 9 Missing ⚠️
src/libfuncs.rs 91.42% 6 Missing ⚠️
src/libfuncs/starknet.rs 68.75% 5 Missing ⚠️
src/libfuncs/nullable.rs 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #919      +/-   ##
==========================================
+ Coverage   82.38%   82.46%   +0.08%     
==========================================
  Files         122      117       -5     
  Lines       34623    34392     -231     
==========================================
- Hits        28523    28362     -161     
+ Misses       6100     6030      -70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

github-actions bot commented Nov 13, 2024

Benchmark results Main vs HEAD.

Command Mean [s] Min [s] Max [s] Relative
base factorial_2M.cairo (JIT) 3.182 ± 0.016 3.150 3.201 1.00
base factorial_2M.cairo (AOT) 3.367 ± 0.017 3.341 3.392 1.06 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head factorial_2M.cairo (JIT) 3.288 ± 0.027 3.251 3.330 1.00
head factorial_2M.cairo (AOT) 3.445 ± 0.014 3.421 3.467 1.05 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base fib_2M.cairo (JIT) 2.727 ± 0.012 2.711 2.747 1.00
base fib_2M.cairo (AOT) 2.917 ± 0.013 2.892 2.932 1.07 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head fib_2M.cairo (JIT) 2.860 ± 0.031 2.797 2.892 1.00
head fib_2M.cairo (AOT) 3.089 ± 0.079 3.006 3.210 1.08 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base logistic_map.cairo (JIT) 3.011 ± 0.019 2.979 3.044 1.00
base logistic_map.cairo (AOT) 3.083 ± 0.011 3.068 3.102 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head logistic_map.cairo (JIT) 3.133 ± 0.024 3.090 3.162 1.00
head logistic_map.cairo (AOT) 3.185 ± 0.025 3.153 3.223 1.02 ± 0.01

edg-l
edg-l previously approved these changes Nov 19, 2024
@azteca1998 azteca1998 added this pull request to the merge queue Nov 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 20, 2024
@edg-l edg-l added the review-ready A PR that is ready for review label Nov 21, 2024
@azteca1998 azteca1998 added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit 107ff62 Nov 21, 2024
32 checks passed
@azteca1998 azteca1998 deleted the coalesce-noop-libfuncs branch November 21, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-ready A PR that is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the no-op libfuncs cleaner
4 participants