Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Garaga test #769

Open
pefontana opened this issue Aug 26, 2024 · 5 comments
Open

Add Garaga test #769

pefontana opened this issue Aug 26, 2024 · 5 comments

Comments

@pefontana
Copy link
Collaborator

Add a test for Garaba contracts
https://github.com/keep-starknet-strange/garaga/tree/main/src/src/tests

@Gerson2102
Copy link
Contributor

Can this be considered too hard? I have contributed before to the project but just on good first issues.

@pefontana
Copy link
Collaborator Author

pefontana commented Aug 27, 2024

Hi @Gerson2102 !
I think it is an easy one!
You also have the alexandria tests in the repo to take as a guide
If you want I can assign you the issue

@Gerson2102
Copy link
Contributor

Yeah, lets see what I can do.

@igaray
Copy link
Collaborator

igaray commented Aug 28, 2024

Hey @Gerson2102 ! Just wanted to make sure you are aware we are not (at the moment) participating in OnlyDust hackathons

@edg-l
Copy link
Collaborator

edg-l commented Oct 21, 2024

I tried this, looks like there is a compilation error, specially with the circuit related libfunc

Steps to reproduce:

# on cairo native
cd cairo_native
cargo b --release --all-features --bin scarb-native-test
cd ..
git clone [email protected]:keep-starknet-strange/garaga.git
cd garaga/src
/abs-path-to/cairo_native/target/release/scarb-native-test
❯ /data2/edgar/work/cairo_native/target/release/scarb-native-test
   Compiling test(garaga_unittest) garaga v0.1.0 (/data2/edgar/work/garaga/src/Scarb.toml)
    Finished `dev` profile target(s) in 22 seconds
testing garaga ...
loc("circuit_add_input(stmt_idx=27295)"("program.sierra":93874:0)): error: 'llvm.extractvalue' op folder produced a value of incorrect type: 'i96', expected: 'i8'
scarb-native-test: /home/edgar/data/llvm-project/mlir/lib/IR/Operation.cpp:624: void checkFoldResultTypes(Operation *, SmallVectorImpl<OpFoldResult> &): Assertion `false && "incorrect fold result type"' failed.
Aborted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants