Added a function to determine if the attachedcluster was created in the cluster #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he cluster Signed-off-by: LiZhenCheng9527 <[email protected]>
✅ Deploy Preview for kurator-dev canceled.
|
hzxuzhonghu
reviewed
Feb 4, 2024
e2e/resources/constant.go
Outdated
|
|
||
| const ( | ||
| // pollInterval defines the interval time for a poll operation. | ||
| pollInterval = 5 * time.Second |
There was a problem hiding this comment.
I've shortened the pollInterval between poll operation.
hzxuzhonghu
reviewed
Feb 4, 2024
| // pollInterval defines the interval time for a poll operation. | ||
| pollInterval = 5 * time.Second | ||
| // pollTimeout defines the time after which the poll operation times out. | ||
| pollTimeout = 420 * time.Second |
There was a problem hiding this comment.
This sets the timeout for getting the attachecluster resource.
You can set it up here:
func WaitAttachedClusterFitWith(client kurator.Interface, namespace, name string, fit func(attachedCluster *clusterv1a1.AttachedCluster) bool) {
gomega.Eventually(func() bool {
attachedClusterPresentOnCluster, err := client.ClusterV1alpha1().AttachedClusters(namespace).Get(context.TODO(), name, metav1.GetOptions{})
if err != nil {
return false
}
return fit(attachedClusterPresentOnCluster)
}, pollTimeout, pollInterval).Should(gomega.Equal(true))
}It will get the attachedcluster every time poolInterval until it succeeds or time over pollTimeout.
Signed-off-by: LiZhenCheng9527 <[email protected]>
LiZhenCheng9527
force-pushed
the
funxtion-waitattachedcluster
branch
from
f53f6ff
to
88c444d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Added a function to determine if the attachedcluster was created in the cluster. Replaces the unstable checking of clusters at fixed intervals.
Which issue(s) this PR fixes:
a part of #436