Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add attachedcluater e2e test #582

Closed
wants to merge 2 commits into from

Conversation

LiZhenCheng9527
Copy link
Contributor

What this PR does / why we need it:
add attachedcluater e2e test
Which issue(s) this PR fixes:
a part of #436

Signed-off-by: LiZhenCheng9527 <[email protected]>
Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for kurator-dev canceled.

Name Link
🔨 Latest commit 185bed2
🔍 Latest deploy log https://app.netlify.com/sites/kurator-dev/deploys/65b1c05d18abbf000819c09d

@kurator-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kevin-wangzefeng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

test/install.sh Outdated
Comment on lines 9 to 12
KUBECONFIG_PATH=${KUBECONFIG_PATH:-"${HOME}/.kube"}
MAIN_KUBECONFIG=${MAIN_KUBECONFIG:-"${KUBECONFIG_PATH}/kurator-host.config"}
export KUBECONFIG=${MAIN_KUBECONFIG}
VERSION=${VERSION:-"0.6.0"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should build from code

Signed-off-by: LiZhenCheng9527 <[email protected]>
helm repo update
sleep 5s

helm install --create-namespace kurator-cluster-operator kurator/cluster-operator --version=${VERSION} -n kurator-system
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we cannot install via helm, because this version is not released yet

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to pull the latest code commits, and use the built images and chart packages to install.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, the code in here, you should not use the helmchart from helm registry

@@ -0,0 +1,52 @@
#!/usr/bin/env bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we should provife e2e case in go, could improve later

helm repo update
sleep 5s

helm install --create-namespace kurator-cluster-operator kurator/cluster-operator --version=${VERSION} -n kurator-system
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, the code in here, you should not use the helmchart from helm registry

@hzxuzhonghu
Copy link
Member

/close

close first, seems break prow tide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants