-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add attachedcluater e2e test #582
Conversation
Signed-off-by: LiZhenCheng9527 <[email protected]>
✅ Deploy Preview for kurator-dev canceled.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
test/install.sh
Outdated
KUBECONFIG_PATH=${KUBECONFIG_PATH:-"${HOME}/.kube"} | ||
MAIN_KUBECONFIG=${MAIN_KUBECONFIG:-"${KUBECONFIG_PATH}/kurator-host.config"} | ||
export KUBECONFIG=${MAIN_KUBECONFIG} | ||
VERSION=${VERSION:-"0.6.0"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should build from code
Signed-off-by: LiZhenCheng9527 <[email protected]>
helm repo update | ||
sleep 5s | ||
|
||
helm install --create-namespace kurator-cluster-operator kurator/cluster-operator --version=${VERSION} -n kurator-system |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we cannot install via helm, because this version is not released yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to pull the latest code commits, and use the built images and chart packages to install.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, the code in here, you should not use the helmchart from helm registry
@@ -0,0 +1,52 @@ | |||
#!/usr/bin/env bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: we should provife e2e case in go, could improve later
helm repo update | ||
sleep 5s | ||
|
||
helm install --create-namespace kurator-cluster-operator kurator/cluster-operator --version=${VERSION} -n kurator-system |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, the code in here, you should not use the helmchart from helm registry
/close close first, seems break prow tide |
What this PR does / why we need it:
add attachedcluater e2e test
Which issue(s) this PR fixes:
a part of #436