Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for sbt-github-actions #299

Merged
merged 3 commits into from
Apr 10, 2021
Merged

Conversation

therealcisse
Copy link
Contributor

@therealcisse therealcisse commented Apr 9, 2021

I'm assuming you have sbt-ci-release already setup for publish.

Copy link
Owner

@kubukoz kubukoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, many thanks! If you can fix the minor issues I pointed out before I merge - please do.

I'll merge as soon as I have enough time to set up the secrets etc. so that it works straight away when it ends up on master.

.mergify.yml Outdated Show resolved Hide resolved
.gitignore Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
@kubukoz
Copy link
Owner

kubukoz commented Apr 9, 2021

I'm assuming you have sbt-ci-release already setup for publish.

Good assumption, I do :) still gotta move the env variables from Travis CI to github.

//sbt-ci-release settings
ThisBuild / githubWorkflowTargetTags ++= Seq("v*")
ThisBuild / githubWorkflowPublishTargetBranches := Seq(
RefPredicate.StartsWith(Ref.Branch("master")),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually thought of having both master and main here, but it's alright :)

@kubukoz
Copy link
Owner

kubukoz commented Apr 10, 2021

Thanks! I'll get it merged now.

@kubukoz kubukoz merged commit 5cc5846 into kubukoz:master Apr 10, 2021
@kubukoz
Copy link
Owner

kubukoz commented Apr 10, 2021

Snapshots published with just a couple changes, so I'd say it's a big success :) we'll see if a tag publishes as well, but if it doesn't, it's probably on me due to a mistake in the secrets.

@kubukoz
Copy link
Owner

kubukoz commented Apr 10, 2021

Eventually worked!

kubukoz pushed a commit that referenced this pull request Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants