-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for sbt-github-actions #299
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good, many thanks! If you can fix the minor issues I pointed out before I merge - please do.
I'll merge as soon as I have enough time to set up the secrets etc. so that it works straight away when it ends up on master.
Good assumption, I do :) still gotta move the env variables from Travis CI to github. |
//sbt-ci-release settings | ||
ThisBuild / githubWorkflowTargetTags ++= Seq("v*") | ||
ThisBuild / githubWorkflowPublishTargetBranches := Seq( | ||
RefPredicate.StartsWith(Ref.Branch("master")), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually thought of having both master and main here, but it's alright :)
Thanks! I'll get it merged now. |
Snapshots published with just a couple changes, so I'd say it's a big success :) we'll see if a tag publishes as well, but if it doesn't, it's probably on me due to a mistake in the secrets. |
Eventually worked! |
I'm assuming you have
sbt-ci-release
already setup for publish.