Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config-example.md #2458

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Update config-example.md #2458

merged 1 commit into from
Nov 19, 2024

Conversation

xLexih
Copy link
Contributor

@xLexih xLexih commented Nov 16, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:

The config-example.md has information for the registry but doesn't assign a node for it.

Added a registry node to improve clarity so people don't miss the potential option.

Which issue(s) this PR fixes:

config-example.md

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:

docs/registry.md

@kubesphere-prow kubesphere-prow bot added release-note-none kind/documentation Categorizes issue or PR as related to documentation. labels Nov 16, 2024
Copy link

Welcome @xLexih! It looks like this is your first PR to kubesphere/kubekey 🎉

@kubesphere-prow kubesphere-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 16, 2024
Copy link

sonarcloud bot commented Nov 16, 2024

@redscholar
Copy link
Collaborator

/approve
/lgtm

@kubesphere-prow kubesphere-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2024
Copy link

LGTM label has been added.

Git tree hash: dc29d0f498042f586dac3c3fdd8785d12c54e260

@liangzai006
Copy link
Collaborator

/lgtm

@pixiake
Copy link
Collaborator

pixiake commented Nov 19, 2024

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pixiake, redscholar, xLexih

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubesphere-prow kubesphere-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2024
@ks-ci-bot ks-ci-bot merged commit e3cfa8a into kubesphere:master Nov 19, 2024
5 checks passed
@pixiake
Copy link
Collaborator

pixiake commented Nov 19, 2024

@all-contributors please add @xLexih for doc

Copy link
Contributor

@pixiake

I've put up a pull request to add @xLexih! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants