Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update feature gate information #48819

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iheartNathan
Copy link
Contributor

Description
fixes this #47996

Issues
Closes: #47996

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 23, 2024
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 23, 2024
Copy link

netlify bot commented Nov 23, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit c21d5c4
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6742366f0f723800081f4a68
😎 Deploy Preview https://deploy-preview-48819--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One error I recommend fixing

/lgtm
The docs are less wrong if we merge this.

@@ -8,7 +8,7 @@ _build:
stages:
- stage: alpha
defaultValue: false
fromVersion: "1.30"
fromVersion: "1.29"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually

Suggested change
fromVersion: "1.29"
fromVersion: "1.26"

IIRC

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c761809c91d8d0f540624fd404a10a9253123296

@iheartNathan iheartNathan force-pushed the 47996-update-feature-gate-information branch from a886d71 to c21d5c4 Compare November 23, 2024 20:09
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2024
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from sftim. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubernetes Feature Gate Information On Website Incorrect For ~6 Features
3 participants