Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kops: Migrate E2E and network-plugins kops-presubmits #32922

Merged
merged 1 commit into from
Jul 8, 2024
Merged

kops: Migrate E2E and network-plugins kops-presubmits #32922

merged 1 commit into from
Jul 8, 2024

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Jul 8, 2024

Ref:

Ensure E2E and network plugins presubmits runs on community-owned infrastructure.

@ameukam
kops: Migrate E2E and network-plugins kops-presubmits
245ca30 
Ref:
  - kubernetes/kops#16637
  - kubernetes/k8s.io#5127

Ensure E2E and network plugins presubmits runs on community-owned
infrastructure.

Signed-off-by: Arnaud Meukam <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 8, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 8, 2024
@ameukam
Copy link
Member Author

ameukam commented Jul 8, 2024

cc @hakman @rifelpet @upodroid

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2024
@hakman
Copy link
Member

hakman commented Jul 8, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 8, 2024
upodroid
upodroid approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel
I see the migrated jobs are launching correctly. ref: kubernetes/kops#16662

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, rifelpet, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 72d4fe6 into kubernetes:master Jul 8, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@ameukam: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kops-presubmits-e2e.yaml using file config/jobs/kubernetes/kops/kops-presubmits-e2e.yaml
  • key kops-presubmits-network-plugins.yaml using file config/jobs/kubernetes/kops/kops-presubmits-network-plugins.yaml

In response to this:

Ref:

Ensure E2E and network plugins presubmits runs on community-owned infrastructure.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ameukam added a commit to ameukam/test-infra that referenced this pull request Jul 8, 2024
@ameukam
update job migration todo
8bbd609 
Ref:
  - kubernetes/k8s.io#5127
  - kubernetes/kops#16637

Update the todo list after:
  - kubernetes#32922
@ameukam ameukam mentioned this pull request Jul 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upodroid upodroid upodroid approved these changes

@rifelpet rifelpet rifelpet approved these changes

@hakman hakman Awaiting requested review from hakman

@johngmyers johngmyers Awaiting requested review from johngmyers

Assignees

@rifelpet rifelpet

@hakman hakman

@upodroid upodroid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ameukam @hakman @k8s-ci-robot @rifelpet @upodroid