-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auto-pause: restart service after configuration #19900
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ComradeProgrammer The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ComradeProgrammer please fix the lint |
d9adcd6
to
b27c6c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fails if auto-pause has already paused the pods.
$ minikube start --addons=auto-pause
...
🏄 Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default
# Wait for auto-pause to pause the pods
$ minikube ssh -- docker ps
CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES
fb89d41715cf 6e38f40d628d "/storage-provisioner" 13 seconds ago Up 12 seconds (Paused) k8s_storage-provisioner_storage-provisioner_kube-system_d52cbb57-0ca1-41aa-b034-21729f201412_1
d1ee449c1051 haproxy "docker-entrypoint.s…" 40 seconds ago Up 39 seconds k8s_auto-pause_auto-pause-proxy-654bcfdc5d-mph86_auto-pause_f4c78ef7-a32b-4258-8ef3-ae091547c1a5_0
00222ed908d8 gcr.io/k8s-minikube/auto-pause-hook "/auto-pause-hook -t…" 43 seconds ago Up 42 seconds k8s_webhook_env-inject-85b8f7f46d-mjpmm_auto-pause_d6da64ed-c118-4609-a226-c753acfd6357_0
473fbc807da3 c69fa2e9cbf5 "/coredns -conf /etc…" 44 seconds ago Up 43 seconds (Paused) k8s_coredns_coredns-7c65d6cfc9-hvsv2_kube-system_d15615d9-a665-40d8-8679-f965d2ca28fd_0
991a0b0998a9 registry.k8s.io/pause:3.10 "/pause" 44 seconds ago Up 44 seconds (Paused) k8s_POD_storage-provisioner_kube-system_d52cbb57-0ca1-41aa-b034-21729f201412_0
f82cb980bf91 505d571f5fd5 "/usr/local/bin/kube…" 45 seconds ago Up 44 seconds (Paused) k8s_kube-proxy_kube-proxy-55cwz_kube-system_401d0ff4-15ac-4cb4-a8fc-363122bbeee7_0
8cff0eee2d73 registry.k8s.io/pause:3.10 "/pause" 45 seconds ago Up 44 seconds k8s_POD_auto-pause-proxy-654bcfdc5d-mph86_auto-pause_f4c78ef7-a32b-4258-8ef3-ae091547c1a5_0
ba590072db6b registry.k8s.io/pause:3.10 "/pause" 45 seconds ago Up 44 seconds k8s_POD_env-inject-85b8f7f46d-mjpmm_auto-pause_d6da64ed-c118-4609-a226-c753acfd6357_0
3727f0ea3b2b registry.k8s.io/pause:3.10 "/pause" 45 seconds ago Up 44 seconds (Paused) k8s_POD_coredns-7c65d6cfc9-hvsv2_kube-system_d15615d9-a665-40d8-8679-f965d2ca28fd_0
efd0e08db135 registry.k8s.io/pause:3.10 "/pause" 45 seconds ago Up 44 seconds (Paused) k8s_POD_kube-proxy-55cwz_kube-system_401d0ff4-15ac-4cb4-a8fc-363122bbeee7_0
5837fd475fdb 0486b6c53a1b "kube-controller-man…" 55 seconds ago Up 54 seconds (Paused) k8s_kube-controller-manager_kube-controller-manager-minikube_kube-system_a0f79d40fa1f417afd22780e833eca6a_0
ad67231ce651 847c7bc1a541 "kube-scheduler --au…" 55 seconds ago Up 54 seconds (Paused) k8s_kube-scheduler_kube-scheduler-minikube_kube-system_b8c9ab2df1ccf7573c3a515e3c781475_0
ea677b6ed62d 9499c9960544 "kube-apiserver --ad…" 55 seconds ago Up 54 seconds (Paused) k8s_kube-apiserver_kube-apiserver-minikube_kube-system_d2ead1331f69543592886560584ea808_0
fdc86a9cccff 2e96e5913fc0 "etcd --advertise-cl…" 55 seconds ago Up 54 seconds (Paused) k8s_etcd_etcd-minikube_kube-system_a5363f4f31e043bdae3c93aca4991903_0
8c5601e2edd4 registry.k8s.io/pause:3.10 "/pause" 55 seconds ago Up 54 seconds (Paused) k8s_POD_kube-controller-manager-minikube_kube-system_a0f79d40fa1f417afd22780e833eca6a_0
2203501708a1 registry.k8s.io/pause:3.10 "/pause" 55 seconds ago Up 54 seconds (Paused) k8s_POD_kube-scheduler-minikube_kube-system_b8c9ab2df1ccf7573c3a515e3c781475_0
b319a80a16be registry.k8s.io/pause:3.10 "/pause" 55 seconds ago Up 54 seconds (Paused) k8s_POD_kube-apiserver-minikube_kube-system_d2ead1331f69543592886560584ea808_0
bf729faab5a2 registry.k8s.io/pause:3.10 "/pause" 55 seconds ago Up 54 seconds (Paused) k8s_POD_etcd-minikube_kube-system_a5363f4f31e043bdae3c93aca4991903_0
$ minikube addons configure auto-pause
-- Enter interval time of auto-pause-interval (ex. 1m0s): 3m
▪ Using image gcr.io/k8s-minikube/auto-pause-hook:v0.0.5
# Hangs here for several minutes
💣 Failed to configure auto-pause minikube
✅ auto-pause was successfully configured
@ComradeProgrammer can you plz take a look ? |
auto-pause: restart service after configuration
FIX #17945
After:
when the cluster is running
when the cluster is not running