Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAS: Update cache on update or delete Topology. #3615

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mbobrovskyi
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fixed bug that doesn't allow to update cache on update or delete Topology.

Which issue(s) this PR fixes:

Fixes #3614

Special notes for your reviewer:

Does this PR introduce a user-facing change?

TAS: Fixed bug that doesn't allow to update cache on update or delete Topology.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Nov 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mbobrovskyi
Once this PR has been reviewed and has the lgtm label, please assign mimowo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 22, 2024
@mbobrovskyi
Copy link
Contributor Author

/test all

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 22, 2024
Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 2d1021c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6740ac62336a6b0009d8a921

@mbobrovskyi mbobrovskyi force-pushed the fix/tas-updates-or-deleted-of-topology branch 2 times, most recently from e4d259c to 667a1aa Compare November 22, 2024 15:50
@mbobrovskyi mbobrovskyi marked this pull request as ready for review November 22, 2024 15:50
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 22, 2024
@mbobrovskyi mbobrovskyi force-pushed the fix/tas-updates-or-deleted-of-topology branch from 667a1aa to a88e3f0 Compare November 22, 2024 16:02
@mbobrovskyi mbobrovskyi force-pushed the fix/tas-updates-or-deleted-of-topology branch from a88e3f0 to 2d1021c Compare November 22, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TAS: Updates or deletion of Topology is not reflected in TAS cache resulting in wrong admission
3 participants