fix spark-rbac

[Aransh]

Purpose of this PR

A recent PR has added support for multiple namespace.
Among the changes it has added the field roleRef.namespace to a roleBinding, this field does not exist and causes issues with deployments. It is also not needed as the roleBinding resource is namespaced to begin with.
You can see a similar discussion here - https://stackoverflow.com/questions/51961432/cant-to-add-namespace-field-to-roleref-in-rolebinding

Proposed changes:

• Remove roleRef.namespace from spark roleBinding

Change Category

Indicate the type of change by marking the applicable boxes:

• Bugfix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that could affect existing functionality)
• Documentation update

Rationale

Checklist

Before submitting your PR, please review the following:

• I have conducted a self-review of my own code.
• I have updated documentation accordingly.
• I have added tests that prove my changes are effective or that my feature works.
• Existing unit tests pass locally with my changes.

Additional Notes

[MatheusAfinovicz]

+1, had the same issue this morning.
Thanks @Aransh 👍🏻

[vara-bonthu]

@AndrewChubatiuk , the support for multiple namespaces was introduced in this commit: GitHub commit link. Have you had a chance to verify if it's working as expected for you? You can also check out the PR raised by @Aransh for more details.

[AndrewChubatiuk]

it's not needed, thanks for removing it

[vara-bonthu]

@Aransh, could you resolve the conflicts so we can proceed with merging the PR? Thank you!

[Aransh]

@vara-bonthu bumped version for this and #1976

[vara-bonthu]

It does look like the checks are still failing. Could you please run the following in your local machine?

https://github.com/kubeflow/spark-operator/blob/master/docs/developer-guide.md#run-helm-chart-lint

and pre-commit https://github.com/kubeflow/spark-operator/blob/master/docs/developer-guide.md#run-helm-chart-lint

We may need to document this better in PR templates

[Aransh]

@vara-bonthu yup seems I'm a bit lost with this 😵‍💫
Every time I bump the version it seems to just ask me to bump it again, anyway ran these tests locally hopefully it's fine now

[vara-bonthu]

/lgtm

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Aransh, vara-bonthu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vara-bonthu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment