Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement Proposal]: make ksctl add-nodes use the bootstrap provider from statefile #26

Closed
2 of 4 tasks
Tracked by #371
dipankardas011 opened this issue May 31, 2024 · 0 comments · Fixed by ksctl/ksctl#445
Closed
2 of 4 tasks
Tracked by #371
Labels

Comments

@dipankardas011
Copy link
Member

dipankardas011 commented May 31, 2024

Enhancement Title

make bootstrapProvider to be taken from statefile if its add-nodes context

Summary of the Enhancement

make bootstrapProvider to be taken from statefile if its add-nodes context

otherwise it user can provide k3s instead of kubeadm and viceversa thus causing runtime logical error

@ksctl/maintainers-for-core

Motivation and Goals

It will also simply the command and we can remove the command line flag for bootstrap and core will figure it out explicitly

Detailed Design

Things we need to think of

Action: need to create a fix for this in the next release

Alternatives

No response

Scope of changes

  • Cli
  • UI
  • Docs

Agreement

  • I agree to engage in constructive discussion and follow the Contribution Guidelines.
@dipankardas011 dipankardas011 changed the title [Enhancement Proposal]: make ksctl add-nodes use the bootstrap provider from statefile [Enhancement Proposal]: make ksctl add-nodes use the bootstrap provider from statefile [BLOCKED] Jun 15, 2024
@dipankardas011 dipankardas011 changed the title [Enhancement Proposal]: make ksctl add-nodes use the bootstrap provider from statefile [BLOCKED] [Enhancement Proposal]: make ksctl add-nodes use the bootstrap provider from statefile Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant