You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am asking because I am using a UI library where the click event in some links is not only used for navigation, but also used by parent elements to change styles for example.
To give some context, in this nav bar:
the nav bar items are augmented with data-navigo, clicking on an item needs also to propagate to the parent element (the nav bar) which is responsible for updating the selection indicator (the white line below the active item).
My suggestion is to make stopPropagation optional (or removing it if there is no obvious reason for using it).
Many thanks.
The text was updated successfully, but these errors were encountered:
I would like to ask if there is a reason for stopping the click event propagation in
navigo/src/index.ts
Line 274 in 8784291
I am asking because I am using a UI library where the click event in some links is not only used for navigation, but also used by parent elements to change styles for example.
To give some context, in this nav bar:
the nav bar items are augmented with
data-navigo
, clicking on an item needs also to propagate to the parent element (the nav bar) which is responsible for updating the selection indicator (the white line below the active item).My suggestion is to make
stopPropagation
optional (or removing it if there is no obvious reason for using it).Many thanks.
The text was updated successfully, but these errors were encountered: