Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make authors of the blog post the link to their info #27

Open
vrom911 opened this issue Aug 20, 2018 · 3 comments
Open

Make authors of the blog post the link to their info #27

vrom911 opened this issue Aug 20, 2018 · 3 comments
Labels
web-page Different tasks with web page design

Comments

@vrom911
Copy link
Member

vrom911 commented Aug 20, 2018

Each author name should be a link to the main page /team/#name.surname

@vrom911 vrom911 added the web-page Different tasks with web page design label Aug 20, 2018
@sphaso
Copy link

sphaso commented Nov 28, 2018

I see two issues with this:

  • the team member modal is currently just that, so we'd need some javascript to act as a router and open the modal
  • the haskell / template part to generate the link :)

Do you agree? Is there any other way you thought to approach this?

@vrom911
Copy link
Member Author

vrom911 commented Nov 29, 2018

@sphaso Yes, I see now that it's a bit complicated as should involve some JS code. For the link part, I was thinking that it's possible to reuse Team module we have as it already has all this information. The thing now a bit more difficult as I thought it would be, cause we have some general posts which are authored as Kowainik, also be can have blog posts with several authors.
Do you think these complications worth it, or that it's doable without tears?

@sphaso
Copy link

sphaso commented Nov 29, 2018

@vrom911 hopefully no tears :)

  1. Regarding general posts, I guess it's just a conditional on the link creation. One could point to the #team route
  2. To do this we might consider adopting a JS router for reduced tears as coding one by hand is not trivial

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
web-page Different tasks with web page design
Projects
None yet
Development

No branches or pull requests

2 participants