Add checkup for Intune #1501
Draft
Add checkup for Intune #1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RebeccaMahany
force-pushed
the
becca/intune-checkup
branch
from
a0d3226
to
41d213b
Compare
Comment on lines
+49
to
+51
| if len(matches) == 0 { | ||
| return fmt.Errorf("no intune agent logs found at %s", agentLogsPathPattern) | ||
| } |
There was a problem hiding this comment.
Is this an error? (It will run on non-intune machines)
There was a problem hiding this comment.
I think I just added this to make it more obvious what was going on when testing -- I'll update to remove here + below
There was a problem hiding this comment.
I think I was mostly quibbling over Errorf vs some debug/info log line, I don't really want to see the error on every flare...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1490