Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: is there (presently) a way to have the bookmarks be stored in the workspace file? #5

Open
carlitorendon opened this issue Sep 2, 2021 · 9 comments

Comments

@carlitorendon
Copy link

When doing Remote SSH development, it seems as if Labeled is storing the bookmarks locally in the client. When I moved to another client (that SSH to the same host) the bookmarks are not there.

Tried to look for a setting override to see if this could be customized but couldn't find any. Any tips or is this not supported yet?

@koalamer
Copy link
Owner

koalamer commented Sep 4, 2021

There are no storage options yet for the extension, everything goes into vscode.ExtensionContext.workspaceState, which is recommended way to do it as far I can tell reading the docs: https://code.visualstudio.com/api/advanced-topics/remote-extensions#persisting-extension-data-or-state

Could you describe your case more closely? Are you using to workstations? Is there a .workspace file for the project? Is it on the remote side, or are there two separate ones? (I haven't used remote development yet, so I need additional info to be able to reproduce your case.)

Side note: issue #4 would require dumping the state into a file, which could work as a solution for this one too, but it would be better to know the cause of your problem.

@carlitorendon
Copy link
Author

Hello @koalamer, thanks for getting back to me. Yeah the use case is simple, say you're doing "remote development" using the Remote support from VSCode.

image

When you have more than one remote client, say one machine at the office and one at home, and the VS Code server lives in the cloud. Ideally you want your labeled bookmarks to be there no matter which client you're using. Kinda like the code, it lives in the server.

So the idea would be to allow labeled-bookmarks to store the bookmark metadata in the .workspace file (which lives in the server) so the bookmarks are there no matter where you connect from.

PS: this feature may also be useful when doing development inside a docker container.

@AmelianceSkyMusic
Copy link

@koalamer I think you can discover another extension «Bookmarks». It saves their settings inside a project folder.

@koalamer
Copy link
Owner

Allright, I'll pick up the thread. This feature request has been lingering for months now...

@Louis-udm
Copy link

Hi,

Thanks for this wonderful extension. and I also need this feature. Also I think It's good that save the data to a project folder

@1024daniel
Copy link

Thanks for this wonderful extension. and I also need this feature. It is awesome if we can save the bookmark in a json file. With that we can git commit the bookmark.

@diegovdev
Copy link

Hi I would also love to be able to store the bookmarks on a json file. That way it can be parto of the repo and it's shared with all the team.

@koalamer
Copy link
Owner

koalamer commented Aug 17, 2023

The related modifications are in a state of hiatus here: https://github.com/koalamer/vsc-labeled-bookmarks/tree/selectable-storage. (Also has some additional features com[ared to the distributed version.)

Some parts are already working, like saving at a custom location, and using a custom file instead of the default location, if I remember correctly. So if you know how to compile the code, you could install and use it amongst colleagues.

Unfortunately, I'm not very motivated to work on finishing this branch lately.
This started out as a pet project and it shows on the quality of the code organization. Also I'm not a JS/TS developer or a fan of developing in JS/TS.
If someone is brave enough, I could guide them to make it happen.

@1024daniel
Copy link

Wish you back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants