Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added include flags to include security context #1954

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

added include flags to include security context #1954

wants to merge 2 commits into from

Conversation

EraKin575
Copy link

Description

Changes

Reference

Fixes #1788

Release Note

made securityContext optional as a include flag

@knative-prow Knative Prow
Copy link

knative-prow bot commented Jun 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: EraKin575
Once this PR has been reviewed and has the lgtm label, please assign maximilien for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow Knative Prow
Copy link

knative-prow bot commented Jun 22, 2024

Hi @EraKin575. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 22, 2024
knative-prow[bot]
knative-prow bot reviewed Jun 22, 2024
View reviewed changes
Copy link

@knative-prow knative-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EraKin575: 0 warnings.

In response to this:

Description

Changes

Reference

Fixes #1788

Release Note

made securityContext optional as a include flag

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

dsimansk
dsimansk reviewed Jun 25, 2024
View reviewed changes
pkg/kn/commands/service/export.go
@@ -127,40 +127,59 @@ func NewServiceExportCommand(p *commands.KnParams) *cobra.Command {
}
flags := command.Flags()
commands.AddNamespaceFlags(flags, false)
flags.StringArray("include", nil, "Include certain info")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to keep the --with-* format of option flags. In this case --with-securit-context or a short form--with-sc.

@dsimansk
Copy link
Contributor

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 25, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jun 25, 2024

@EraKin575: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-tests_client_main 4f43783 link true /test unit-tests
build-tests_client_main 4f43783 link true /test build-tests
integration-tests-latest-release_client_main 4f43783 link true /test integration-tests-latest-release
integration-tests_client_main 4f43783 link true /test integration-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dprotaso dprotaso removed their request for review June 25, 2024 18:46
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 5, 2024
@knative-prow-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow knative-prow[bot] knative-prow[bot] left review comments

@dsimansk dsimansk dsimansk left review comments

@itsmurugappan itsmurugappan Awaiting requested review from itsmurugappan

Assignees
No one assigned
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Service export should handle securityContext field
3 participants
@EraKin575 @dsimansk @knative-prow-robot