Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed year change issue when updated in date picker #56

Merged
merged 1 commit into from
Oct 25, 2021
Merged

Fixed year change issue when updated in date picker #56

merged 1 commit into from
Oct 25, 2021

Conversation

ayushAB
Copy link
Contributor

@ayushAB ayushAB commented Oct 21, 2021

Fixed issue with the date not updating when changed the year with buttons or with editable input for the date picker.
How i fixed it

  • the change event for the date picker was emitting the change event directly so i have create a new method in the DateInput component that checks with the range provided and then sets the date accordingly.

Note: There were some warning related to linting have also fixed that.

@ayushAB ayushAB changed the base branch from master to develop October 21, 2021 10:12
@ayushAB ayushAB mentioned this pull request Oct 21, 2021
Open
@ayushAB
Copy link
Contributor Author

ayushAB commented Oct 21, 2021

#55

@ayushAB ayushAB changed the title Fixed year change issue when update in date picker Fixed year change issue when updated in date picker Oct 25, 2021
@kleinrein
Copy link
Owner

Thanks! This looks good 👍

@kleinrein kleinrein merged commit 544d003 into kleinrein:develop Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayushAB @kleinrein