Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: deployment simulation returns empty data #1488

Open
enitrat opened this issue Oct 23, 2024 · 0 comments
Open

bug: deployment simulation returns empty data #1488

enitrat opened this issue Oct 23, 2024 · 0 comments
Labels
bug Inconsistencies or issues which will cause a problem for users or implementors.

Comments

@enitrat
Copy link
Contributor

enitrat commented Oct 23, 2024

safe-global team wants to deploy singleton factory, however, the simulation returns empty bytecode (which means if it is deployed wrongly - it can not be undone as nonce has been already used and contract address won't be usable as there is no code).
Here is a contract deployment data:

curl -s https://sepolia-rpc.kakarot.org/ -H 'content-type: application/json' --data '{"jsonrpc":"2.0","id":0,"method":"eth_call","params":[{"data":"0x604580600e600039806000f350fe7fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffe03601600081602082378035828234f58015156039578182fd5b8082525050506014600cf3"},"latest"]}'

There were similar issues for other networks (etherlink and swisstronik), maybe those discussions will also be helpful:
safe-global/safe-singleton-factory#678
safe-global/safe-singleton-factory#545

Edit*
To add how they simulate: (call example)

  1. simulate the contract deployment (e.g. try to use their signer -> call with deployment data)
  2. check if get_Code returns result (if it is not 0x - then it would be deployed well)
  3. but if it does return 0x - then something reverted, was wrong and contract was not deployed BUT transaction would be pushed, nonce used and other singleton will have a different address - which in this case is unfavorable.

we need to check why this is not returning the right data.

@enitrat enitrat added the bug Inconsistencies or issues which will cause a problem for users or implementors. label Oct 23, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Backlog in Kakarot on Starknet Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Inconsistencies or issues which will cause a problem for users or implementors.
Projects
No open projects
Status: 🆕 Backlog
Development

No branches or pull requests

1 participant