Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stCreate2::create2collisionStorage #661

Open
enitrat opened this issue Mar 4, 2024 · 1 comment
Open

stCreate2::create2collisionStorage #661

enitrat opened this issue Mar 4, 2024 · 1 comment
Labels
wontfix This will not be worked on

Comments

@enitrat
Copy link
Contributor

enitrat commented Mar 4, 2024

  • create2collisionStorage_d0g0v0_Shanghai: fails because the account has no code nor nonce and a storage that is not empty initially. The expected behavior is that the storage is cleared - however, we do not clear the storage on purpose, as This can only happen in the following highly unlikely circumstances:

    • The address created by a CREATE call collides with a subsequent CREATE or CREATE2 call.
    • The first CREATE happened before Spurious Dragon and left empty code - which cannot happen in our case
  • create2collisionStorage_d1g0v0_Shanghai: same issue, previous storage not cleared

  • create2collisionStorage_d2g0v0_Shanghai: same

@enitrat enitrat added the bug Something isn't working label Mar 4, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Backlog in Kakarot on Starknet Mar 4, 2024
@enitrat enitrat added wontfix This will not be worked on and removed bug Something isn't working labels Mar 4, 2024
@ClementWalter
Copy link
Member

should we do something here then? or is it just like that and we don't care (but add a doc somewhere with know failing cases)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
No open projects
Status: 🆕 Backlog
Development

No branches or pull requests

2 participants